Change the Elections' setup minimum hours before start setting to 1 hour#10900
Merged
Change the Elections' setup minimum hours before start setting to 1 hour#10900
Conversation
f7ba559 to
b9a1fbf
Compare
alecslupu
suggested changes
May 30, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Genererating a new application will provide a default value of 3, due to generator template. Could you fix this, please?
Member
Author
I've missed that one, nice catch! Done at 340cce0 |
alecslupu
added a commit
that referenced
this pull request
Jun 2, 2023
fblupi
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
alecslupu
added a commit
that referenced
this pull request
Jun 14, 2023
* Fix error message mismatch in election * Fixing hour pluralization after #10900
This was referenced Jun 15, 2023
andreslucena
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Fix error message mismatch in election * Fix error message mismatch in election * Fixing hour pluralization after #10900 * Apply review recommendations * Fix the failing spec
andreslucena
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Fix error message mismatch in election * Fix error message mismatch in election * Fixing hour pluralization after #10900 * Apply review recommendations * Fix the failing spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When working with an Election, by default you need to set it up 3 hours before it starts. This means that every single time that you need to try one Election you need to do it 3 hours before.
This PR changes this to 1 hour, as it makes sense to development and also to production/staging instances. Mind that this is an Env Var that can be changed in the different installations, and in a real-world Election this actually should be done a couple days before.
Testing
📷 Screenshots