Conversation
fblupi
approved these changes
Apr 11, 2023
Member
fblupi
left a comment
There was a problem hiding this comment.
@alecslupu Maybe we could refactor the publish_event methods changing their name to send_notification. I think it would make it more consistent as there are too many methods with this name making Decidim::EventsManager.publish(...) and a few with the same functionality with the name publish_event.
This change isn't in the scope of this PR. We could include it in a new one.
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Added a new method to publicable behavior, that is checking the versions of the resource for any changes on published_at field.
If this method returns true, then the notifications like will not be duplicated.
If the method returns true, then the above notifications will be displayed.
📌 Related Issues
Link your PR to an issue
Testing
For Spaces:
For resources:
📷 Screenshots
Please add screenshots of the changes you are proposing
