The failing specs are caused by Picmo, which is fixed by #10291

Ping @andreslucena @decidim/product

Please see the review I left above. The proposal attachments functionality is currently inconsistent between the admin side and the participant side.

@ahukkanen I agree. In fact in the front end the image and document input is split. Maybe we could simplify it so that it works the same on both sides.

I would leave the "Add attachment" option for everything, implement multiple attachment upload in the admin, and correct the inconsistency in the guidance texts for uploading documents and images. We should modify them by explaining that the first attached image is displayed on the card.

Do you want me to create the issue Antti, or you create it? Also, do you think this is something doable under the Maintainers scope of work or it's too much effort?

@carolromero

In fact in the front end the image and document input is split. Maybe we could simplify it so that it works the same on both sides.

It is also split in the admin panel right now. At admin, you can upload both image(s) and document:

I was actually only referring to the attachments control but after this comment I went ahead and looked at it again. Even funnier thing about this is that actually admin allows uploading multiple images but only one attachment. And in the participant side it is flipped. 😄

I would leave the "Add attachment" option for everything

I would not. For users it is conceptually important to separate the "main" image (i.e. the card image) of the proposal and any additional attachments they'd like to add.

And also, it becomes really hard to change the card image in case we put them to the same input. You would have to delete all the existing attachments, add the updated image as the first one, and finally re-add all the other attachments.

We do not currently have the support in the UI to reorder the attachments and the first image attachment is always used as the card/main image for the proposal. If the user has to know or guess this behavior, it will be confusing for most.

implement multiple attachment upload in the admin

Yes, this is what I would also do and what I was referring to above as well.

In the admin the upload functionality should match the participant side regarding both of these uploads (one image and multiple attachments).

correct the inconsistency in the guidance texts for uploading documents and images

I think the guidance is already good at the participant side, so if we apply the same guidance in the admin panel, it would be OK.

We should modify them by explaining that the first attached image is displayed on the card.

I'm not sure how easy this is to implement, it might get complex as we've tried to generalize the upload guidance texts so that we wouldn't have to define them for each and every upload button separately.

I would possibly separate this to its own issue, just in case it turns out to be complex to implement (I don't remember off the back of my head).

Do you want me to create the issue Antti, or you create it?

I'd kindly ask you to review what I wrote above and see if it makes sense to you. If it does, go ahead and create the issue (or feel free to adjust).

Also, do you think this is something doable under the Maintainers scope of work or it's too much effort?

I would think this is doable in the maintainers scope but not necessarily with the highest possible priority. I'd give it low or medium priority.