Backport 'Fix importing a page component without a body' to v0.26#10023
Merged
andreslucena merged 2 commits intorelease/0.26-stablefrom Nov 4, 2022
Merged
Conversation
* Add page in AssemblyImporter JSON example * Add spec for pages imported without body * Add guard clause for pages imported without body
Contributor
Author
|
@andreslucena The build is broken at 0.26 after merging #9959. This should fix that. |
This was referenced Nov 2, 2022
Merged
Member
|
FYI, last failing spec is from a flaky that was already solved in develop and v0.27 at #9175 |
Contributor
Author
|
Thanks @andreslucena ! LGTM, so to me this is ready to be merged! |
Member
|
Oh I didn't realize that this was actually one backport made by you, sorry for the commit 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #9863 to v0.26