Backport 'Fix proposal etiquette and length validator with base64 images' to v0.26#10010
Merged
ahukkanen merged 3 commits intorelease/0.26-stablefrom Nov 3, 2022
Conversation
* Fix proposal etiquette and length validator with base64 images * Use strip_tags instead of nokogiri not to include hidden content Content e.g. in `<script>` tags should be automatically hidden, so this should not be included in the validation either. * Fix the expected base64 mime types
ahukkanen
requested changes
Nov 1, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Build is broken because of a typo/different Ruby version.
decidim-proposals/spec/validators/proposal_length_validator_spec.rb
Outdated
Show resolved
Hide resolved
ahukkanen
requested changes
Nov 2, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Seems to be one more incompatibility with 0.26.
decidim-proposals/spec/validators/proposal_length_validator_spec.rb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #9639 to v0.26