Fixed image editor component pattern#7586
Merged
martinjagodic merged 1 commit intodecaporg:mainfrom Sep 1, 2025
Merged
Conversation
martinjagodic
approved these changes
Sep 1, 2025
martinjagodic
pushed a commit
to poslovnimediji/decap-cms
that referenced
this pull request
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
patternprop of the Image editor component and fixes the issue #7575.The problem was that the previous regex pattern expected the image Markdown to occupy the entire string, using ^ at the start and $ at the end. As a result, images embedded in Markdown blocks with preceding or trailing text, blank lines, or paragraphs were not detected, breaking the editor preview for these images.
The proposed solution removes the $ anchor at the end and uses a global regex that matches images anywhere in the Markdown block. This ensures that images like:
are correctly recognized by the Image editor component and rendered in both the rich text editor and preview pane.
Test plan
Here is an example of the Docusaurus demo content with an image between paragraphs:
Checklist
Please add a
xinside each checkbox: