Move polyfill resolution from webpack to package.json#7395
Merged
martinjagodic merged 22 commits intodecaporg:mainfrom Jul 10, 2025
Merged
Move polyfill resolution from webpack to package.json#7395martinjagodic merged 22 commits intodecaporg:mainfrom
martinjagodic merged 22 commits intodecaporg:mainfrom
Conversation
Contributor
Author
|
Update: I noticed that With this change in place, we could also remove the |
fgnass
added a commit
to fgnass/decap-cms
that referenced
this pull request
Feb 25, 2025
Member
|
@fgnass, I agree with the |
Member
|
I take it back. This PR solves #7521, so I would merge as is. |
martinjagodic
previously approved these changes
Jun 27, 2025
martinjagodic
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the setup for users consuming
decap-cms-appdirectly by addressing Node.js built-in dependencies in a different way.Problem:
path)decap-cms-appdirectly must manually configure their build tools to provide these polyfillsSolution:
browserfield inpackage.jsonto specify browser-compatible alternatives@iarna/toml/parse-stringinstead of full@iarna/tomlto eliminatestreamdependencyminimatchto a more recent version which removes Node.js built-in dependenciesThese changes make the library more portable and easier to integrate across different build environments.
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
🐣