test(traefik): skip TestCustomGlobalConfig on Rancher Desktop, fixes #8167 (#8283) [skip ci]#8283
Merged
test(traefik): skip TestCustomGlobalConfig on Rancher Desktop, fixes #8167 (#8283) [skip ci]#8283
Conversation
…8167 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Download the artifacts for this pull request:
See Testing a PR.
|
Contributor
|
Howdy, I'll spin up a VM with Rancher to review this. |
Member
Author
|
Thanks. This is only macOS (we don't test on Rancher on Windows). And it's intermittent, so this PR just gives up on it. |
Contributor
|
ah! scratch that idea then. :)
…On Fri, Apr 3, 2026 at 11:43 AM Randy Fay ***@***.***> wrote:
*rfay* left a comment (ddev/ddev#8283)
<#8283?email_source=notifications&email_token=AADZ6YGH2GIK6WBSYHW53JT4T7L2JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJYGM4TSOJUGMZ2M4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4183999433>
Thanks. This is only macOS (we don't test on Rancher on Windows). And it's
intermittent, so this PR just gives up on it.
—
Reply to this email directly, view it on GitHub
<#8283?email_source=notifications&email_token=AADZ6YGH2GIK6WBSYHW53JT4T7L2JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJYGM4TSOJUGMZ2M4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4183999433>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZ6YD3MCIK5M5NBP7NKXL4T7L2JAVCNFSM6AAAAACXL43CF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOBTHE4TSNBTGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
TestCustomGlobalConfigregularly fails on Rancher Desktop. The test expects a custom Traefik middleware header (X-Test-Custom-Global: ddev-test-value) but intermittently gets an empty string on Rancher Desktop.How This PR Solves The Issue
Adds a skip guard for Rancher Desktop, consistent with how other Traefik tests (
TestTraefikSimple,TestTraefikStaticConfig) handle unreliable behavior on Lima-based providers. The guard can be overridden withDDEV_RUN_TEST_ANYWAY=true.Manual Testing Instructions
TestCustomGlobalConfigon Rancher Desktop and confirm it skipsDDEV_RUN_TEST_ANYWAY=trueto confirm the override worksAutomated Testing Overview
The skip only applies to Rancher Desktop; all other providers continue to run the test.
Release/Deployment Notes
No user-facing changes — test-only fix.