Skip to content

Conversation

@catwith1hat
Copy link

No description provided.

@LenardHess
Copy link
Contributor

Hello,
the gandi API update has already been done in this commit (a57cb3b). See also #602 for more

@LenardHess LenardHess closed this Feb 25, 2024
@catwith1hat
Copy link
Author

The comments in #602 wrong. API keys still work. So you just surprise broke all your Gandi users with the other backward incompatible PR. I would revert the other PR and merge this one before you cut a new release. But that's your choice.

@LenardHess
Copy link
Contributor

In that case I'll get #626 reverted then and this one looked at, thanks for the info 👍

@LenardHess
Copy link
Contributor

LenardHess commented Mar 2, 2024

I do not want the password string to have a magic prefix - especially considering that when (if?) gandi kills the support for API keys, we want to remove support for the old method and make the PAT method the only one available. Having those updates affect the details on how to format the password entry is messy.

I tried a different route in #636 - using a separate config bool variable.

@catwith1hat
Copy link
Author

@LenardHess Whatever works for you. I don't have a strong opinion.

@rhansen
Copy link
Member

rhansen commented Mar 16, 2024

See #602 (comment) for additional alternative approaches.

@LenardHess
Copy link
Contributor

Merged #636, closing this one

@LenardHess LenardHess closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants