Skip to content

gandi improvements #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LenardHess merged 2 commits into from
Nov 25, 2023
Merged

gandi improvements #558

LenardHess merged 2 commits into from
Nov 25, 2023

Conversation

@TinfoilSubmarine
Copy link
Contributor

@TinfoilSubmarine TinfoilSubmarine commented Aug 1, 2023

No description provided.

@LenardHess
Copy link
Contributor

LenardHess commented Aug 1, 2023

When using wantipv4/wantipv6, the provider implementation has to then set status-ipv4/status-ipv6 instead of status, ipv4/ipv6 instead of ip and so on.

I admit the rules for this aren't clearly written down yet, we went over some details in this pull request (while in a fork, so other repo): rrthomas#10

@TinfoilSubmarine TinfoilSubmarine force-pushed the fix/gandi branch 2 times, most recently from 09ea180 to 08a8ba1 Compare August 1, 2023 21:53
@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Aug 1, 2023

Is this better? I also added skipping the update if the record is already set to the same IP.

@TinfoilSubmarine TinfoilSubmarine force-pushed the fix/gandi branch 2 times, most recently from 0a23439 to 451de37 Compare August 2, 2023 02:30
@TinfoilSubmarine TinfoilSubmarine changed the title gandi: update logic to allow updating IPv6/AAAA gandi improvements Aug 2, 2023
@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Aug 10, 2023

FYI, I'm done making revisions on this.

@LenardHess
Copy link
Contributor

LenardHess commented Aug 12, 2023

Thanks for the update (again 😉)

We will leave this pull request open until v3.11.0 has been released (see #552 (comment) for details). It will get pulled into v3.11.1

@LenardHess LenardHess added provider Adds, fixes or removes a provider. not-in-this-release Won't yet be handled in the upcoming release labels Aug 12, 2023
@LenardHess
Copy link
Contributor

LenardHess commented Oct 21, 2023

Same as #557 - please rebase onto master for the merge.

@LenardHess LenardHess removed the not-in-this-release Won't yet be handled in the upcoming release label Oct 21, 2023
LenardHess
LenardHess reviewed Oct 25, 2023
View reviewed changes
LenardHess
LenardHess requested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@LenardHess LenardHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a few things i still noticed - Apologies for not noticing them the first time around.
The "Nitpick" stuff isn't urgent, feel free to skip those suggestions.

@TinfoilSubmarine TinfoilSubmarine force-pushed the fix/gandi branch 3 times, most recently from 62b82c7 to b0a7267 Compare November 24, 2023 20:52
@TinfoilSubmarine
gandi: update logic
5ec8bfe 
- allow updating IPv6/AAAA
- allow updating A and AAAA records simultaneously
- skip updating if record already has same IP
@TinfoilSubmarine
gandi: improve documentation
846ab59
LenardHess
LenardHess approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@LenardHess LenardHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@LenardHess LenardHess merged commit e0611ab into ddclient:master Nov 25, 2023
@TinfoilSubmarine TinfoilSubmarine deleted the fix/gandi branch October 14, 2024 12:55
@chenrui333 chenrui333 mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LenardHess LenardHess LenardHess approved these changes

Assignees

No one assigned

Labels

provider Adds, fixes or removes a provider.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TinfoilSubmarine @LenardHess