Skip to content

porkbun: rework logic to allow for simultaneous update of IPv4 and IPv6 #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LenardHess merged 1 commit into from
Oct 25, 2023
Merged

porkbun: rework logic to allow for simultaneous update of IPv4 and IPv6 #557

LenardHess merged 1 commit into from
Oct 25, 2023

Conversation

@TinfoilSubmarine
Copy link
Contributor

@TinfoilSubmarine TinfoilSubmarine commented Jul 31, 2023 •
edited
Loading

Just had a look at the diff and it was not too obvious what I did, so here's the gist:

  • Update porkbun logic to properly handle dual updates to IPv4 and IPv6 at one time
  • Also slightly deduplicated the porkbun logic by unifying the ipv4 and ipv6 logic using $ipv

@TinfoilSubmarine TinfoilSubmarine force-pushed the fix/porkbun branch 2 times, most recently from fe8c73b to 84ea5cd Compare August 1, 2023 03:51
@LenardHess LenardHess added provider Adds, fixes or removes a provider. IPv6 Issues or pull request related to ipv6. labels Aug 1, 2023
@LenardHess
Copy link
Contributor

LenardHess commented Aug 1, 2023

From a quick glimpse of the old code - it doesn't seem like simultaneous IPv4 and IPv6 was broken?

Cleanup/Refactor looks good to me though 👍

I assume you're using porkbun and tested this?

@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Aug 1, 2023 •
edited
Loading

From a quick glimpse of the old code - it doesn't seem like simultaneous IPv4 and IPv6 was broken?

That's what I was confused about, but I think that the next calls were messing it up. I didn't verify that this was true though.

Cleanup/Refactor looks good to me though 👍

I assume you're using porkbun and tested this?

Yes, testing it out directly on the Porkbun API with multiple domains, root domain, etc.

@TinfoilSubmarine TinfoilSubmarine force-pushed the fix/porkbun branch 2 times, most recently from 4975c4c to a8f4c1a Compare August 2, 2023 01:48
@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Aug 2, 2023

OK, sorry for another set of revisions to the commit, but I didn't like the addition of the extra function when the same thing could be accomplished with a foreach. Logic remains the same.

@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Aug 10, 2023

FYI, I'm done making revisions on this.

@LenardHess
Copy link
Contributor

LenardHess commented Aug 12, 2023

Thanks for the update!

We will leave this pull request open until v3.11.0 has been released (see #552 (comment) for details). It will get pulled into v3.11.1

@LenardHess LenardHess added the not-in-this-release Won't yet be handled in the upcoming release label Aug 12, 2023
@jortkoopmans jortkoopmans mentioned this pull request Oct 20, 2023
Closed
@LenardHess
Copy link
Contributor

LenardHess commented Oct 21, 2023

With v3.11.0 released, please rebase ontop of current master.

@LenardHess LenardHess removed the not-in-this-release Won't yet be handled in the upcoming release label Oct 21, 2023
@LenardHess LenardHess mentioned this pull request Oct 21, 2023
Merged
@LenardHess LenardHess merged commit e2ce23e into ddclient:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IPv6 Issues or pull request related to ipv6. provider Adds, fixes or removes a provider.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TinfoilSubmarine @LenardHess