Update dependencies to prevent audit warnings#29
Merged
dciccale merged 6 commits intodciccale:masterfrom Apr 20, 2021
digitalica:master
Merged
Update dependencies to prevent audit warnings#29dciccale merged 6 commits intodciccale:masterfrom digitalica:master
dciccale merged 6 commits intodciccale:masterfrom
digitalica:master
Conversation
|
Nice! I was going to submit master...jacquerie:bump-deps-for-security as a PR, but I see that you've done the same thing in a superior way. |
Contributor
Author
|
thanks.... looks i was a little more complete, in also updating the
template function. It should be deprecated I think: people who use it
probably should use their own underscore.... Anyway. Fix done ;-)
…On Tue, Dec 18, 2018 at 5:53 PM Jacopo Notarstefano < ***@***.***> wrote:
Nice! I was going to submit master...jacquerie:bump-deps-for-security
<master...jacquerie:bump-deps-for-security>
as a PR, but I see that you've done the same thing in a superior way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACo2a0sBjhJxMIj8DouHbj4ZmY2QgIrAks5u6R2XgaJpZM4ZRog9>
.
--
Robbert Wethmar
Digitalica
Jan Evertsenstraat 144 A4
1056 EK Amsterdam
phone 020 8932884
mobile 06 53804879
skype rwethmar
|
|
@dciccale please merge and version bump to avoid security warnings |
|
@digitalica would you be commiting your last pull request to fix audit issues |
|
@dciccale Any chance this can get merged soon? |
Owner
|
published 0.3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies. Most importantly lodash, to prevent audit warnings.
Before: found 11 vulnerabilities (2 low, 5 moderate, 3 high, 1 critical) in 174 scanned packages
After: found 0 vulnerabilities (better, right?)
As lodash is an important part of htmlprocessor, there may be functionality changes (!)
Test added for the template prototype method in htmlprocessor.js (line 120) as it is used by dependencies, was not tested, and params changed by lodash. This is one obvious functionality change.