Use CLOCK_BOOTTIME and mach_continuous_time#44
Closed
bikallem wants to merge 1 commit intodbuenzli:masterfrom
bikallem:correct-sleep-behaviour
Closed
Use CLOCK_BOOTTIME and mach_continuous_time#44bikallem wants to merge 1 commit intodbuenzli:masterfrom bikallem:correct-sleep-behaviour
bikallem wants to merge 1 commit intodbuenzli:masterfrom
bikallem:correct-sleep-behaviour
Conversation
Owner
|
Thanks, your patch is in as a7bfe32 (I added a few doc bits it). |
dbuenzli
reviewed
Dec 2, 2022
| @@ -51,14 +54,14 @@ CAMLprim value ocaml_mtime_clock_elapsed_ns (value unit) | |||
| static uint64_t start = 0L; | |||
| if (start == 0L) { start = mach_absolute_time (); } | |||
Owner
There was a problem hiding this comment.
Just for the record there is a bug here. You forgot to update that to mach_continuous_time.
dbuenzli
added a commit
that referenced
this pull request
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10