Merged
Conversation
scottnemes
approved these changes
Jan 20, 2026
Contributor
scottnemes
left a comment
There was a problem hiding this comment.
Looks good assuming we want to keep supporting DSA. Imagine a lot of older servers and what not still use it, so probably good for now I suppose if we want to remain compatible.
paramiko 4.x no longer supports DSA keys, and can cause MyCLI to exit
with a cryptic error if the user has a DSA key present:
module 'paramiko' has no attribute 'DSSKey'
See paramiko/paramiko#2537
01419d5 to
6e1c33f
Compare
Contributor
Author
The issue is that MyCLI simply exits if the user has a DSA key under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Paramiko 4.x no longer supports DSA keys, and can cause MyCLI to exit with a cryptic error if the user has a DSA key present:
See paramiko/paramiko#2537
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.