Skip to content

[BUG] - Removal of DSSKey class broke pysftp downstream, even if not using the keys #2537

@nneul

Description

@nneul

Are you using paramiko as a client or server?

Client

What feature(s) aren't working right?

SFTP

What version(s) of paramiko are you using?

4.0.0

What version(s) of Python are you using?

3.11

What operating system and version are you using?

Debian Bookworm

If you're connecting as a client, which SSH server are you connecting to?

NA

If you're using paramiko as part of another tool, which tool/version?

pysftp 0.2.9

Expected/desired behavior

I 100% understand this is an issue in the downstream library, however, LOTS of tools use pysftp wrapper, and this is likely unintentional. Would you consider returning the DSSKey class to paramiko and throwing a runtime exception instead if it is actually used?

As currently implemented in 4.0.0 it breaks even an import of latest pysftp even if DSA keys are not actually being used.

Actual behavior

  File "/local/app/bin/./gen-feed.py", line 11, in <module>
    import pysftp
  File "/local/app/pyenv/lib/python3.11/site-packages/pysftp/__init__.py", line 14, in <module>
    from paramiko import AgentKey, RSAKey, DSSKey
ImportError: cannot import name 'DSSKey' from 'paramiko' (/local/app/pyenv/lib/python3.11/site-packages/paramiko/__init__.py)

How to reproduce

import pysftp

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions