Shift + Click range selection improvements#439
Merged
davidstutz merged 4 commits intodavidstutz:masterfrom Feb 13, 2015
Merged
Conversation
-> See https://bugzilla.mozilla.org/show_bug.cgi?id=559506 -> Removed the javascript:void(0) href for anchor elements in the multiselect dropdown -> Added a tabindex = 0 to keep the anchors focus-able -> Added code to remove any text selection when using shift+click -> Handles the checkbox selection manually when done using shift+click on its label
…-selection ** -> Now able to select/deselect ranges -> The range is based on the previously active checkbox. (i.e: the user clicks a checkbox no 1 then checkbox no 5. The interval will be [1,5].) -> The range new state (selected or deselected) depends on the last option clicked new value. Example: If the checkbox is Shift-clicked and becomes selected, the whole range will be too. -> Improved the range select speed tremendously by only notifying the select for the "change" event once the whole range finished changing and manually doing the selection or deselection.
Closed
-> Fixed a failure on test for davidstutz#405 due to the code changes
…lect into shift-select-improvement
davidstutz
added a commit
that referenced
this pull request
Feb 13, 2015
Shift + Click range selection improvements. Fixes #431.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Based on the code in the pull request #435.
Changes:
-> Now able to select/deselect ranges
-> The range is based on the previously active checkbox. (i.e: the user clicks a checkbox no 1 then checkbox no 5. The interval will be [1,5].)
-> The range new state (selected or deselected) depends on the last option clicked new value. Example: If the checkbox is Shift-clicked and becomes selected, the whole range will be too.
-> Improved the range select speed tremendously by only notifying the select for the "change" event once the whole range finished changing and manually doing the selection or deselection.