Filtering & optgroups#395
Merged
davidstutz merged 2 commits intodavidstutz:masterfrom Oct 13, 2014
ehouais:filtering-&-optgroups
Merged
Filtering & optgroups#395davidstutz merged 2 commits intodavidstutz:masterfrom ehouais:filtering-&-optgroups
davidstutz merged 2 commits intodavidstutz:masterfrom
ehouais:filtering-&-optgroups
Conversation
Altered filtering rules for optgroups * Optgoup header is visible if at least one of its item is visible * All optgroups items are visible if optgroup name satisfies filter The resulting behaviour seems more consistent to me.
Owner
|
Thanks. |
davidstutz
added a commit
that referenced
this pull request
Oct 13, 2014
Correct filtering with optgroups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altered filtering rules for optgroups
The resulting behaviour seems more consistent to me.