default includeSelectAllDivider, switch to div#277
default includeSelectAllDivider, switch to div#277thorst wants to merge 1 commit intodavidstutz:masterfrom
Conversation
There isnt a need to have divider be an li. If it is you have to add a bunch of mods on existing jQuery selectors, in order not to catch that one
|
👎 since I don't think it's valid HTML to have a div as a direct child of a UL. |
|
The search is already a div within a list. If you want to conform to standards then just have the first li contain the search, select all, and select all divider. |
|
dividers can appear in places anywhere in the list - not just the top |
|
that's technically true, but I'm not sure why you would use dividers over groups. curious on your thoughts on the search box.... |
|
I use dividers to logically (and visually) separate optgroups from optgroups that would have a single option (since having an empty optgroup doesn't make sense)
yup, the search div should be inside an |
|
I agree with @philfreo. For now I will not merge this request (thanks anyway!), but I think about making the templates configurable. This would solve this problem. |
There isnt a need to have divider be an li. If it is you have to add a bunch of mods on existing jQuery selectors, in order not to catch that one. Make it a div, it looks the same, and doesnt break other features