EOF edits#14
Merged
davidraythompson merged 1 commit intoJan 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
instrumentor include a wrapper call inForwardin the style of e.g.xa.calc_meascall. The second is indmeas_dinstrument.fm.eof_offsetfunction to calculate the offset at a given super-pixel value. The "shifted" measurement is calculated ininverse_simpleinstead ofanalytical_line.pyanalytical_line.py, although this requires a dedicated PR and some work to better abstract and add in the ability to "smooth" any arbitrary state-vector element.I did minimal testing. I used an example EOF file David provided to ensure that the EOF scale values moved around during inversion. I can't comment on the quality of the solutions. I also haven't deployed at the scene scale. I can test to confirm the AOE changes if need be.