feat: moarstats add normalized mutual info
#3256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fixed n_pairs not being counted properly in the parallel path; it was counted properly in the sequential path.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds normalized mutual information (NMI) as a 6th bivariate statistic to the moarstats command and fixes an n_pairs counting issue in the parallel path.
Key Changes:
- Adds normalized mutual information (NMI) computation using the formula NMI = MI / sqrt(H(X) * H(Y))
- Fixes n_pairs counting in the parallel execution path to use max of correlation_state.count and total_pairs
- Updates documentation, help text, and error messages to include the new NMI statistic
Contributor
|
@jqnatividad I've opened a new pull request, #3257, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3254