Deduplicate NMI computation logic in moarstats bivariate stats #3257
+83
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NMI (Normalized Mutual Information) computation logic was duplicated between parallel and sequential code paths in
moarstats, requiring bug fixes and improvements to be applied in two places.Changes
Extracted
compute_nmi_with_thresholdhelper function encapsulating:Replaced 118 lines of duplicated code with single function calls in both parallel (lines 2463-2477) and sequential (lines 2796-2810) paths
Example
Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.