Parametrize tests for ignore_tz, dayfirst, yearfirst #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
requested changes
Mar 1, 2019
Member
pganssle
left a comment
There was a problem hiding this comment.
Minor changes on this one.
As an aside, I do think some (maybe many) of these tests can be switched over to being hypothesis tests. We are barely using "can invert strftime for unambiguous format strings" anywhere.
Contributor
Author
|
Good ideas all around on the comments, will update. |
92758a6 to
7dc4895
Compare
These tests have uninformative names, so they have been gathered into three parametetrized tests.
These test that various `strftime` formats are invertable by the parser, for the chosen date, they are all unambiguous. and independent of time. In the future, at least some of these can be moved into a property test that does not hard code the format or the date.
This improves the organization of the test cases and also allows us to skip all tests requiring TZEnvContext at the class level.
pganssle
approved these changes
Mar 6, 2019
Contributor
Author
|
anything else needed/requested for this or #891? |
Member
|
@jbrockmendel Heh, just was waiting for CI to pass and then completely forgot about it, thanks for the ping. |
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these tests have uninformative names and no comments, so nothing is lost by parametrizing them.
This shouldn't create merge conflicts with #891 and #892. I'll wait on these three before doing the next round.
Will add a changelog momentarily