Remove duplicate tests #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
reviewed
Feb 26, 2019
|
|
||
|
|
||
| class TestInputFormats(object): | ||
| class TestInputTypes(object): |
Contributor
Author
There was a problem hiding this comment.
Because whats being tested here is different types: bytes vs unicode vs bytearray vs StringIO...
Member
There was a problem hiding this comment.
Ah, I was a bit thrown by the fact that the first test is just an empty string. I see now.
Contributor
Author
|
Looks like no rebase needed. |
Member
|
@jbrockmendel Can you add a changelog? |
Contributor
Author
|
done |
Since all the TestInputFormats tests are about different input *types*, TestInputTypes is a more descriptive name.
pganssle
approved these changes
Feb 27, 2019
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check so that duplicates don't sneak back in.
Rename TestInputFormats to the more accurate TestInputTypes.
A couple more test-cleanup PRs coming up (one with an actual bugfix), trying to keep them small and orthogonal.