Fix for B.Y.d format corner case #687 #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #698.
At the moment
_ymd.resolve_ymdcan ignoreystridxanddstridxin some corner cases. This PR hasresolve_ymdcheck if enough of[ystridx, mstridx, dstridx]have been specified to uniquely pin down (year, month, day), and if so, use those instead of other heuristics.Edits resolve_ymd to prevent deleting an element in-place, which makes step-through debugging more difficult.
Closes #687
Pull Request Checklist