Fix for B.Y.d format corner case #687 #698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jbrockmendel You may want to make this branch on your fork for now, because both Appveyor and Travis are set up to build against both branches and PRs, and I don't know how to set it up to do exactly one build. I think I might disable branch builds entirely. |
Contributor
Author
|
Woops, my bad. Will fix. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
At the moment
_ymd.resolve_ymdcan ignoreystridxanddstridxin some corner cases. This PR has resolve_ymd check if enough of [ystridx, mstridx, dstridx] have been specified to uniquely pin down (year, month, day), and if so, use those instead of other heuristics.Closes #687
Pull Request Checklist