Skip to content

Conversation

@ElliotJH
Copy link
Contributor

Produced at the spring with @kvn219 and @huangy22.

Documentation improvements for the relativedelta class.

Happy to take feedback on our alternative wording.

Cheers for a good fun event!

@pganssle
Copy link
Member

@ElliotJH @kvn219 @huangy22 Can you add yourselves to the AUTHORS.md file?

In alphabetical order, e-mails can be masked out or not. If you'd prefer to just post that information here I can add it myself.

Also, can you add a 673.doc.rst news fragment to the changelog, as described in CONTRIBUTING.md?

@ElliotJH
Copy link
Contributor Author

@pganssle I've added myself to AUTHORS.md I'm happy to update the changelog, but I can't find where the file is supposed to go? (Probably I'm missing something perfectly clear and obvious, so apologies in advance!)

@kvn219 and @huangy22 if you drop me an email I can add you to the authors list too, or else I'm adding you write permissions on my branch.

@pganssle
Copy link
Member

The news file goes in changelog.d

ElliotJH added a commit to ElliotJH/dateutil that referenced this pull request Apr 14, 2018
@pganssle pganssle added this to the Master milestone Apr 14, 2018
@huangy22 huangy22 mentioned this pull request Apr 16, 2018
3 tasks
ElliotJH and others added 4 commits April 15, 2018 20:53
This is referenced in paragraph 7 of the docstring but is easy to miss
and we intend to change it.

Authored with:
- @kvm219
- @huangy22

Co-authored-by: Yuan Huang <huangy22@gmail.com>
Co-authored-by: Kevin Nguyen <kvn219@nyu.edu>
- More clearly explain the order of operations.
- Provide an example of how these operations are applied.
- Remove all references to tuples, which never worked in the first place.

Co-authored-by: Yuan Huang <huangy22@gmail.com>
Co-authored-by: Kevin Nguyen <kvn219@nyu.edu>
Co-authored-by: Yuan Huang <huangy22@gmail.com>
Co-authored-by: Kevin Nguyen <kvn219@nyu.edu>
@pganssle pganssle force-pushed the tuple-documentation-fix branch from 762bb8f to c01c4ba Compare April 16, 2018 00:55
@pganssle
Copy link
Member

I rewrote the history here so that all three authors got "official" credit on all commits.

@pganssle pganssle merged commit 556ce20 into dateutil:master Apr 16, 2018
@pganssle pganssle mentioned this pull request May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants