Quickfix: assertion before setting mstridx #408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If that branch was reached, asserting `mstridx == -1` immediately after setting `mstridx = len(ymd)-1` should always fail (`ymd` is not empty at this point). I'll circle back to add a test case to cover this.
Member
|
This is a bit bizarre. I think maybe we should figure out if it's even possible for that assertion to be incorrect and maybe raise a more appropriate message than @jbrockmendel Did you run into this in the wild, or discover it when reading the code? |
Contributor
Author
|
Reading the code. I spent some time refactoring common patterns to try to cut down the big while loop in If I disable the error-catching, I can trigger this assertion with "2016-15-May". It looks like it only gets reached when the month is at the end, so it makes sense that it would be rare. |
jbrockmendel
added a commit
to jbrockmendel/dateutil
that referenced
this pull request
Jul 4, 2017
Contributor
Author
|
This PR was made with GH's editor as a quick-fix. Replacing it with a fully-fledged PR #409. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that branch was reached, asserting
mstridx == -1immediately after settingmstridx = len(ymd)-1should always fail (ymdis not empty at this point). I'll circle back to add a test case to cover this.