Add JSON Codec for Vector type #476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2023
msmygit
approved these changes
Jun 13, 2023
| return new JsonNodeToCqlVectorCodec( | ||
| vectorType, | ||
| createJsonNodeConvertingCodec(vectorType.getSubtype(), codecFactory, false), | ||
| TypeCodecs.FLOAT, |
Member
There was a problem hiding this comment.
Not a concern for now, but OSS C* is [planning on] adding support for vectors with many different types and not just floats here
Collaborator
There was a problem hiding this comment.
Worth noting: the rework of this functionality in the main PR for adding vector search to dsbulk does not make any assumptions as to the subtype of the input vector.
absurdfarce
pushed a commit
that referenced
this pull request
Jun 14, 2023
Collaborator
|
This code has been reworked in the main PR adding vector support to dsbulk (see this commit). I would argue this PR should be closed in favor of that work. |
Author
|
Closing the PR as it has been superseded |
weideng1
added a commit
that referenced
this pull request
Jun 22, 2023
* Java driver version upgrade (to get vector support) * Initial impl of vector support for loading * Formatting changes * Add vector support to minimal internal CQL parser * Adding support for JSON codecs. This work is significantly inspired by work by @eolivelli (#476) * use newer maven version to workaround WAGON-545 --------- Co-authored-by: weideng1 <weideng1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is based on #475
It adds the implementation for JsonNodeToCqlVectorCodec.java, that allows users to deal with the new CqlVector data type