seqcli index (list|suppress) and seqcli expressionindex (create|list|remove) commands
#337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Apr 23, 2024
Member
nblumhardt
left a comment
There was a problem hiding this comment.
Had a few ideas/suggestions but LGTM 👍
| if (resource.Equals("expressionindex")) | ||
| { | ||
| return "expressionindexes"; | ||
| } |
Member
There was a problem hiding this comment.
FWIW checking for trailing x and adding es would work in most cases, matching the y case below?
| _connectionFactory = connectionFactory ?? throw new ArgumentNullException(nameof(connectionFactory)); | ||
|
|
||
| Options.Add( | ||
| "expression=", |
|
|
||
| _output.ListEntities(list); | ||
|
|
||
| await Task.Delay(1); |
|
|
||
| Options.Add( | ||
| "i=|id=", | ||
| "The id of an index of a signal to suppress", |
Member
There was a problem hiding this comment.
Could drop of a signal here? The server might change around this point
|
|
||
| var connection = _connectionFactory.Connect(_connection); | ||
| var toSuppress = await connection.Indexes.FindAsync(_id); | ||
| if (toSuppress.IndexedEntityType != IndexedEntityType.Signal) |
Member
There was a problem hiding this comment.
Could we make the request and let the server give the reason for any 400 response?
| await ExportTemplates<ExpressionIndexEntity>( | ||
| id => _connection.ExpressionIndexes.FindAsync(id), | ||
| () => _connection.ExpressionIndexes.ListAsync(), | ||
| expressionIndex => expressionIndex.Id.Replace("expressionindex-", ""), |
Member
There was a problem hiding this comment.
=> expressionIndex.Expression.All(char.IsLetterOrDigit) ? expressionIndex.Expression : expressionIndex.Id.Replace("expressionindex-", "") might improve file naming for trivial indexes?
seqcli index (list|suppress) and seqcli expressionindex (create|list|remove) commands
nblumhardt
added a commit
that referenced
this pull request
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.