feat: add getContents() for reading external markdown files into table descriptions#2138
Conversation
|
/gcbrun |
kolina
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution!
Overall looks good, I've left some not very big comments to address.
Currently tests are failing due to expired BQ credentials, can you please rebase your PR onto #2139 so I can re-run them?
|
Thanks for the comments! Working on the fixes! |
8cf17c1 to
cf359f2
Compare
…n on getContents to include limits
|
@kolina ready for another check 🫡 |
|
/gcbrun |
…nto table descriptions (#2138)" (#2155) It broke compilation in GCP https://issuetracker.google.com/509294486
|
@AmmanuelT, unfortunately I had to revert your commit in #2155 because it broke compilation in GCP. I think the reason for breakage is that we use pure V8 for compilation in GCP and we can't use NodeJs modules like |
|
Sorry about that! I'll get that replaced! |
Closes #1723
Allows users to source table descriptions from external markdown files, keeping .sqlx files smaller and enabling reusable, renderable descriptions across the project.
Usage:
Changes:
Notes: