Fix test failures caused by numpy upgrade.#1659
Merged
ueshin merged 1 commit intodatabricks:masterfrom Jul 17, 2020
Merged
Conversation
Collaborator
Author
|
We might want to fix the behavior to follow the new numpy's behavior, but fixing tests here to unblock other PRs. |
Collaborator
Author
|
I'd merge this for now. |
ueshin
added a commit
to ueshin/databricks-koalas
that referenced
this pull request
Jul 21, 2020
This reverts commit 9a2099e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since numpy 1.19,
np.deletecame to fail on out-of-bounds indices (numpy/numpy#15804) and pandas will as well since it depends on numpy.