Added permissions support for Lakebase Database projects#4626
Merged
andrewnester merged 4 commits intomainfrom Mar 4, 2026
Merged
Added permissions support for Lakebase Database projects#4626andrewnester merged 4 commits intomainfrom
andrewnester merged 4 commits intomainfrom
Conversation
Collaborator
|
Commit: 61ee600
20 interesting tests: 7 KNOWN, 7 SKIP, 5 BUG, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
denik
approved these changes
Mar 3, 2026
| // Postgres projects store their hierarchical name ("projects/{project_id}") as the state ID, | ||
| // but the permissions API expects just the project_id. | ||
| if strings.HasPrefix(baseNode, "resources.postgres_projects.") { | ||
| objectIdRef = prefix + "${" + baseNode + ".project_id}" |
Contributor
There was a problem hiding this comment.
nit / possible follow up: we configure prefix via GetAPIRequestObjectType, can we (should we?) have similar configuration for id field?
pietern
approved these changes
Mar 3, 2026
| @@ -0,0 +1,5 @@ | |||
| Local = true | |||
| Cloud = false | |||
Contributor
There was a problem hiding this comment.
Why no cloud? Do we run any of the other permissions tests against cloud?
Contributor
Author
There was a problem hiding this comment.
All the tests in permissions skip the cloud indeed
| + "method": "PUT", | ||
| + "path": "/api/2.0/permissions/database-projects/test-project" | ||
| + } | ||
| +] |
Contributor
Author
There was a problem hiding this comment.
I believe so, it's the same output for the other resources too
Collaborator
|
Commit: 85f43e9
46 interesting tests: 16 FAIL, 16 RECOVERED, 8 KNOWN, 4 flaky, 1 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added permissions support for Lakebase Database projects
Why
Permissions are supported in TF provider and API hence expanding to DABs
Tests
Added an acceptance test