Merged
Conversation
Member
nsheff
commented
Mar 11, 2026
- Fix closest() nearest-neighbor search to use bidirectional expanding scan instead of fixed ±2 window that missed true nearest neighbors (5 new tests)
- Replace unsafe native-endian f64 serialization in signal.rs with safe explicit little-endian encoding, bump SIGM_VERSION to 2 (3 new tests)
- Fix WASM classify_bed_js to return Result instead of panicking on error
- Fix R binding integer casts: add checked_u32 helper for i32→u32 inputs, change outputs from Vec to Vec to prevent truncation (10 new tests)
…, R casts - Fix closest() nearest-neighbor search to use bidirectional expanding scan instead of fixed ±2 window that missed true nearest neighbors (5 new tests) - Replace unsafe native-endian f64 serialization in signal.rs with safe explicit little-endian encoding, bump SIGM_VERSION to 2 (3 new tests) - Fix WASM classify_bed_js to return Result instead of panicking on error - Fix R binding integer casts: add checked_u32 helper for i32→u32 inputs, change outputs from Vec<i32> to Vec<f64> to prevent truncation (10 new tests)
sanghoonio
added a commit
that referenced
this pull request
Mar 11, 2026
Resolve conflicts from gdist-edits PR (#244) merge: - regionset_ops: Keep min_overlap on RegionSetOverlaps trait (needed by R bindings), delegate to MCO batch methods for fast path (min_bp <= 1), fall back to in-place iteration with overlap-size filtering for min_bp > 1. Add 7 new tests for min_overlap edge cases. - genomicdist.rs: Combine gtars-lola's chrom_sizes params and no-reduce partition fix with dev's checked_u32 input validation. - multi_chrom_overlapper.rs: Fix MCO consistency test to pass min_overlap. - region_set.rs (Python): Update callers for min_overlap signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nsheff
added a commit
that referenced
this pull request
Mar 11, 2026
Resolve conflict: interval_ranges.rs deleted on this branch, modified on dev (PR #244 closest() fix + R cast safety). The closest() improvements are already in RegionSet::closest(). R/WASM safe-cast changes from dev merge cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.