Skip to content

Support for latest ipykernel/ipywidgets#8253

Merged
crusaderky merged 3 commits intodask:mainfrom
crusaderky:ipy_versions
Oct 13, 2023
Merged

Support for latest ipykernel/ipywidgets#8253
crusaderky merged 3 commits intodask:mainfrom
crusaderky:ipy_versions

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Oct 10, 2023 •
edited
Loading

@crusaderky crusaderky requested a review from fjetter as a code owner October 10, 2023 12:59
@crusaderky crusaderky self-assigned this Oct 10, 2023
@crusaderky crusaderky mentioned this pull request Oct 10, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±0         21 suites  ±0   11h 12m 6s ⏱️ + 11m 37s
  3 856 tests ±0    3 745 ✔️  -   2     108 💤 +1    3 ❌ +1 
37 283 runs  ±0  35 454 ✔️  - 10  1 812 💤 +9  17 ❌ +1 

For more details on these failures, see this check.

Results for commit c42bb40. ± Comparison against base commit 97074d2.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both. 
distributed.diagnostics.tests.test_widgets
distributed.diagnostics.tests.test_widgets ‑ test_fast
distributed.diagnostics.tests.test_widgets ‑ test_multi_progressbar_widget
distributed.diagnostics.tests.test_widgets ‑ test_multibar_complete
distributed.diagnostics.tests.test_widgets ‑ test_multibar_func_warns
distributed.diagnostics.tests.test_widgets ‑ test_multibar_with_spans
distributed.diagnostics.tests.test_widgets ‑ test_progressbar_cancel
distributed.diagnostics.tests.test_widgets ‑ test_progressbar_done
distributed.diagnostics.tests.test_widgets ‑ test_progressbar_widget
distributed.diagnostics.tests.test_widgets ‑ test_serializers
…

distributed.diagnostics.tests.test_progress_widgets
distributed.diagnostics.tests.test_progress_widgets ‑ test_fast
distributed.diagnostics.tests.test_progress_widgets ‑ test_multi_progressbar_widget
distributed.diagnostics.tests.test_progress_widgets ‑ test_multibar_complete
distributed.diagnostics.tests.test_progress_widgets ‑ test_multibar_func_warns
distributed.diagnostics.tests.test_progress_widgets ‑ test_multibar_with_spans
distributed.diagnostics.tests.test_progress_widgets ‑ test_progressbar_cancel
distributed.diagnostics.tests.test_progress_widgets ‑ test_progressbar_done
distributed.diagnostics.tests.test_progress_widgets ‑ test_progressbar_widget
distributed.diagnostics.tests.test_progress_widgets ‑ test_serializers
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both. 
distributed.diagnostics.tests.test_widgets

distributed.diagnostics.tests.test_progress_widgets
This pull request skips 1 test. 
distributed.tests.test_config ‑ test_schema

@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Oct 10, 2023

Test failures unrelated

hendrikmakait
hendrikmakait approved these changes Oct 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky!

@hendrikmakait
Copy link
Copy Markdown
Member

hendrikmakait commented Oct 12, 2023

Given that we remove ipywidgets <8.0.5, it seems like support for ipywidgets 6 might not be the correct title. Am I missing something here?

@crusaderky crusaderky changed the title Support for ipywidgets 6 Support for latest ipykernel/ipywidgets Oct 13, 2023
@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Oct 13, 2023

Given that we remove ipywidgets <8.0.5, it seems like support for ipywidgets 6 might not be the correct title. Am I missing something here?

I must have misread something.

@crusaderky crusaderky merged commit f9b0abd into dask:main Oct 13, 2023
@crusaderky crusaderky deleted the ipy_versions branch October 13, 2023 16:29
crusaderky added a commit to crusaderky/distributed that referenced this pull request Feb 20, 2024
@crusaderky
Unpin ipywidgets on Python 3.12
ed18af2 
Complements dask#8253
@crusaderky crusaderky mentioned this pull request Feb 20, 2024
Merged
crusaderky added a commit that referenced this pull request Feb 20, 2024
@crusaderky
Unpin ipywidgets on Python 3.12 (#8516)
9c85467 
Complements #8253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graingert graingert graingert approved these changes

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

@crusaderky crusaderky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI broken: The ipykernel.comm.Comm class has been deprecated

3 participants

@crusaderky @hendrikmakait @graingert