Update minimum bokeh version message#7172
Conversation
|
@jrbourbeau Shall we add the maximum bokeh version in this same PR? |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 23m 23s ⏱️ + 13m 54s For more details on these failures, see this check. Results for commit e94b27e. ± Comparison against base commit 6afce9c. |
|
I'd prefer to keep that for a separate PR. I'm hoping we can make things compatible with |
|
Planning to merge in the next 48 hours if no further comment |
) Closes #7227 - Prior to #7172 , the `bokeh` package was an optional dependency. (In the sense that you could start a cluster without bokeh installed) - In the most recent release (`2022.10.1`), `bokeh` became a required depdency due to the import of `distributed.dashboard.core` in `missing_bokeh` which raises an ImportError if bokeh is not installed. - Not _strictly_ required, since the dashboard can be disabled by passing `dashboard_address=None` to the constructor of the Cluster. Which allows use of `distributed==2022.10.1` without bokeh installed. This PR moves the min bokeh variable to a different module that doesn't import code from the dashboard.
Currently we're giving conflicting version for installing with
conda(1.0) andpip(2.1.1). This PR makes it so we specify the minimumbokehversion once and then use that value where needed.