Revert getaddrinfo fast path for python 3.8#6978
Merged
crusaderky merged 1 commit intodask:mainfrom Aug 31, 2022
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 25m 43s ⏱️ - 17m 14s Results for commit c19251e. ± Comparison against base commit 817ead3. |
crusaderky
approved these changes
Aug 31, 2022
Member
Author
|
FWIW running with the debugging settings yields indeed an exception |
gjoseph92
pushed a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #6847
This change introduced a regression in
distributed.tests.test_client::test_reconnectthat only affects python 3.8 versions (mostly OSX but rarely also ubuntu)I suggest to remove this optimization for 3.8
FWIW On my fork I triggered a run using the in #6847 (comment) proposed getaddrinfo performance debugging in case this reveals anything useful, see https://github.com/fjetter/distributed/actions/runs/2963091290