Change memory bars color on spilling/paused status#6959
Merged
crusaderky merged 1 commit intodask:mainfrom Aug 26, 2022
Merged
Conversation
gjoseph92
approved these changes
Aug 25, 2022
Collaborator
gjoseph92
left a comment
There was a problem hiding this comment.
I love this change and will be so happy to see it.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 46m 5s ⏱️ + 5m 1s For more details on these failures, see this check. Results for commit 55d9f93. ± Comparison against base commit 31cd316. |
2 tasks
gjoseph92
pushed a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn the GUI memory bar for a worker to orange when it passes the target threshold, and to red when it pauses or enters its graceful retirement stage.
The cluster bar changes accordingly to orange if there's at least one worker spilling and to red if there's at least one worker paused or retiring.
In main: individual worker bars change to orange when above 50% and to red when above 100%.
The cluster bar changes to orange when the total cluster memory is above 50% and to red when above 100%.
Demo