Ignore spurious warnings in test_quiet_close_process#6955
Merged
Conversation
eea3ebf to
4c01945
Compare
fjetter
approved these changes
Aug 25, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
A different approach could be to change the client script to
import warnings
from dask.distributed import Client
allowed_warnings = [
...
]
if __name__ == "__main__":
for msg in allowed_warnings:
warnings.filterwarings("ignore", msg)
client = Client(processes=%s, n_workers=1, scheduler_port=0, dashboard_address=":0")I'm OK either way
Collaborator
Author
|
@fjetter my approach however has the advantage that, if the spurious warnings start cropping up every time, the test will fail. |
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files + 1 15 suites +1 6h 43m 29s ⏱️ + 1h 5m 2s For more details on these failures, see this check. Results for commit 4c01945. ± Comparison against base commit b8d1c7b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6582
Of course, an exceptionally slow VM could print out "Creating scratch directories is taking a surprisingly long time" five times in a row - we'll iterate again if it happens.