Conversation
1 task
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 33m 22s ⏱️ + 32m 25s For more details on these failures and errors, see this check. Results for commit 84435c1. ± Comparison against base commit 4af2d0a. |
Collaborator
Author
|
All failures are #6731 |
fjetter
approved these changes
Aug 5, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
This test is a good candidate to be rewritten using worker state events w/out actual servers being involved.
Fix looks good enough to me
gjoseph92
added a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6831. This is the "guarantee the worker gets killed before it can transfer the data" approach.
pre-commit run --all-files