Ignore warning for unclose SSHCluster in tests#6827
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 49m 32s ⏱️ + 12m 48s For more details on these failures and errors, see this check. Results for commit a5ac127. ± Comparison against base commit 192a8bb. |
|
@graingert you've looked at this SSHCluster a bit? |
|
There are a couple of tests that are not necessarily closing SSHCluster properly. Some are instantiating the object but not awaiting or closing it. Both can leave a cluster dangling. While this may be worth fixing, I don't think it's worth it right now and would prefer just ignoring this warning unless there is concern that this would indeed negatively impact other tests |
|
I think this is only happening due to xfailed tests that should be skipped |
|
This was intended as a quick fix. I'm doubtful that it's worth our time right now to poke around to see if skipping/xfailing a bunch of tests will resolve this. Particularly, since this is not guaranteed to trigger |
I don't think this is worth raising.
Closes #6771
Closes #6653