Skip to content

Ignore warning for unclose SSHCluster in tests#6827

Merged
fjetter merged 1 commit intodask:mainfrom
fjetter:ignore_warning_unclosed_sshcluster
Aug 8, 2022
Merged

Ignore warning for unclose SSHCluster in tests#6827
fjetter merged 1 commit intodask:mainfrom
fjetter:ignore_warning_unclosed_sshcluster

Conversation

@fjetter
Copy link
Copy Markdown
Member

@fjetter fjetter commented Aug 4, 2022

I don't think this is worth raising.

Closes #6771
Closes #6653

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 4, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 49m 32s ⏱️ + 12m 48s
  2 989 tests ±0    2 895 ✔️  - 5       89 💤 +1  4 +3  1 🔥 +1 
22 165 runs  ±0  21 114 ✔️  - 4  1 045 💤  - 1  5 +4  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit a5ac127. ± Comparison against base commit 192a8bb.

@gjoseph92
Copy link
Copy Markdown
Collaborator

@graingert you've looked at this SSHCluster a bit?

@fjetter
Copy link
Copy Markdown
Member Author

fjetter commented Aug 5, 2022

There are a couple of tests that are not necessarily closing SSHCluster properly. Some are instantiating the object but not awaiting or closing it. Both can leave a cluster dangling.

While this may be worth fixing, I don't think it's worth it right now and would prefer just ignoring this warning unless there is concern that this would indeed negatively impact other tests

@graingert
Copy link
Copy Markdown
Member

I think this is only happening due to xfailed tests that should be skipped

Copy link
Copy Markdown
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to skip the xfailed Macos ssh tests?

@fjetter
Copy link
Copy Markdown
Member Author

fjetter commented Aug 5, 2022

This was intended as a quick fix. I'm doubtful that it's worth our time right now to poke around to see if skipping/xfailing a bunch of tests will resolve this. Particularly, since this is not guaranteed to trigger

@graingert graingert self-requested a review August 6, 2022 07:34
@fjetter fjetter merged commit 93c90eb into dask:main Aug 8, 2022
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky tests: ResourceWarning: unclosed cluster SSHCluster Flaky test_cluster_dump_plugin

3 participants