Skip to content

Set MALLOC_TRIM_THRESHOLD_ before interpreter start#6681

Merged
crusaderky merged 1 commit intodask:mainfrom
crusaderky:nanny_env_variables
Jul 7, 2022
Merged

Set MALLOC_TRIM_THRESHOLD_ before interpreter start#6681
crusaderky merged 1 commit intodask:mainfrom
crusaderky:nanny_env_variables

Conversation

@crusaderky
Copy link
Collaborator

Closes #5971

@crusaderky crusaderky self-assigned this Jul 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  +       3         15 suites  +3   6h 48m 22s ⏱️ + 1h 57m 4s
  2 919 tests +       1    2 838 ✔️ +     11    80 💤  -   11  1 +1 
21 613 runs  +4 117  20 671 ✔️ +3 995  941 💤 +121  1 +1 

For more details on these failures, see this check.

Results for commit 7cba62b. ± Comparison against base commit f7f6501.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the nanny_env_variables branch from f293599 to 7cba62b Compare July 6, 2022 17:06
@crusaderky crusaderky marked this pull request as ready for review July 6, 2022 17:06
process running the Nanny.

For the same reason, be warned that changing
``distributed.worker.multiprocessing-method`` from ``spawn`` to ``fork`` or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the problems with forkserver, but why fork? The variables should be set before the fork happens, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the MALLOC_TRIM_THRESHOLD_ variable is read when the glibc initialises itself, and in case of fork it's already initialised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distributed.nanny.environ.MALLOC_TRIM_THRESHOLD_ is ineffective

2 participants