deprecate passing stopped loops to LoopRunner (and therefore Client/Cluster)#6680
deprecate passing stopped loops to LoopRunner (and therefore Client/Cluster)#6680
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 30m 25s ⏱️ + 25m 31s For more details on these failures, see this check. Results for commit 24ea2d5. ± Comparison against base commit a53858a. ♻️ This comment has been updated with latest results. |
|
Tests / test (macos-latest, 3.8, not ci1) (pull_request) #6683 |
1bd380a to
d017f39
Compare
d017f39 to
8a99fa3
Compare
|
the test_ssh tests are xfailed on macos, however because they are xfailed rather than skipped they still run, and when they fail they leave an unclosed SSHCluster object alive. Which is then garbage collected in the scope of the next test: macos-latest 3.8 not c1: |
|
I'm seeing: test (macos-latest, 3.8, ci1) |
gjoseph92
left a comment
There was a problem hiding this comment.
@graingert if you think this is ready, I'll merge
|
@gjoseph92 yeah I think this is ready, thanks! |
Refs #6163
pre-commit run --all-files