Merged
Conversation
Contributor
Unit Test Results 15 files ± 0 15 suites ±0 6h 14m 56s ⏱️ - 18m 58s For more details on these failures, see this check. Results for commit f84e8f7. ± Comparison against base commit 5feb171. ♻️ This comment has been updated with latest results. |
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 20, 2022
Merged
8 tasks
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 21, 2022
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 21, 2022
3e566c0 to
ab8f4e9
Compare
8 tasks
fjetter
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5896
This feels... overdesigned. However, it was the only way I could find to make the busy workers reinsertion mechanics work within the worker state machine redesign.
I would suggest going going for this for the time being and then pen in later on a review that reworks the algorithm itself.