Refactor find_missing and refresh_who_has#6348
Merged
crusaderky merged 1 commit intodask:mainfrom Jun 1, 2022
Merged
Conversation
8eb8eea to
56c796c
Compare
Contributor
56c796c to
cbccc86
Compare
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 18, 2022
Collaborator
Author
|
As the git tree has become messy, until #6342 is merged the diff of this PR is visible at crusaderky#3 |
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 20, 2022
Merged
8 tasks
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 21, 2022
crusaderky
added a commit
to crusaderky/distributed
that referenced
this pull request
May 21, 2022
45dc795 to
2f96f32
Compare
Collaborator
Author
|
@fjetter this has been updated to reflect the new update_who_has. |
Collaborator
Author
|
Ironically, with this PR some changes that we just introduced in the update_who_has PR can now be reverted: df488f0 |
c0b2bd4 to
50f83d2
Compare
fjetter
approved these changes
Jun 1, 2022
Comment on lines
+2861
to
+2862
| if not isinstance(stim, FindMissingEvent): | ||
| self.stimulus_log.append(stim.to_loggable(handled=time())) |
Member
There was a problem hiding this comment.
I assume you're logging this because it is flooding the log otherwise?
Collaborator
Author
There was a problem hiding this comment.
Correct. Plus, it's really not interesting to see in the log even when relevant. Note that the response from the scheduler is logged.
This was referenced Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure_communicatingtransitions to new WorkerState event mechanism #5896Additional changes to #6342 are visible at crusaderky#3
Refactor Worker->Scheduler queries to fetch who_has, from RPC to bulk comms. This removes one of the two async commands in
gather_dep(the other being the actual data request) and is propaedeutic to its refactoring.Fix minor bug where: