Do not require pytest_timeout for utils_test#6224
Merged
crusaderky merged 1 commit intodask:mainfrom Apr 27, 2022
Merged
Conversation
This was referenced Apr 27, 2022
Member
Author
|
For reference, the pytest-timeout code is available here https://github.com/pytest-dev/pytest-timeout/blob/7745a09ffe6c2f46d0807a99f1d12458f87c0055/pytest_timeout.py#L195-L221 |
Member
Author
|
I'm open to vendoring the entire logic, of course. I would just like to avoid having to maintain that list of known debuggers |
Contributor
Collaborator
|
I agree that vendoring everything is overkill |
crusaderky
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6218
downstream users are frequently using utils_test and we should not promote pytest-timeout to a runtime dependency just for that. This replacement captures the gist of the logic although pytest-timeout is dealing with many edge cases. I think we're fine without these edge cases in most situations