Skip to content

Increase test timeout if debugger is running#6218

Merged
mrocklin merged 1 commit intodask:mainfrom
fjetter:increase_timeout_when_debugger_runs
Apr 27, 2022
Merged

Increase test timeout if debugger is running#6218
mrocklin merged 1 commit intodask:mainfrom
fjetter:increase_timeout_when_debugger_runs

Conversation

@fjetter
Copy link
Copy Markdown
Member

@fjetter fjetter commented Apr 27, 2022

This effectively disables the asyncio test timeout if a debugger is running.

Copy link
Copy Markdown
Member

@mrocklin mrocklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool. +1

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

       16 files  ±0         16 suites  ±0   7h 46m 11s ⏱️ -41s
  2 739 tests ±0    2 656 ✔️  - 1       80 💤  - 1  2 +1  1 🔥 +1 
21 798 runs  +1  20 748 ✔️ +2  1 047 💤  - 3  2 +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 3b0fd7c. ± Comparison against base commit 84cbb09.

@mrocklin
Copy link
Copy Markdown
Member

CI Failures here are interesting (new to me) but pretty clearly unrelated I think.

@mrocklin mrocklin merged commit 6fb095e into dask:main Apr 27, 2022
@fjetter fjetter deleted the increase_timeout_when_debugger_runs branch April 27, 2022 14:41
@crusaderky
Copy link
Copy Markdown
Collaborator

This breaks dask/dask dask/dask#8963 (comment)

@fjetter
Copy link
Copy Markdown
Member Author

fjetter commented Apr 27, 2022

see #6224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants