Conversation
2 tasks
Contributor
Unit Test Results 17 files + 6 17 suites +6 9h 5m 22s ⏱️ + 3h 24m 26s For more details on these failures, see this check. Results for commit 2ac24e5. ± Comparison against base commit ed48736. ♻️ This comment has been updated with latest results. |
madsbk
reviewed
Mar 30, 2022
Contributor
madsbk
left a comment
There was a problem hiding this comment.
LGTM but I suggest that the test is moved to test_to_pickle.py.
Member
Author
|
Planning to merge when CI finishes. |
Member
Author
|
Also, it looks like ToPickle fails with inproc comms. |
Member
Author
|
Maybe we need this? diff --git a/distributed/protocol/serialize.py b/distributed/protocol/serialize.py
index b4daf5bd..48091cc5 100644
--- a/distributed/protocol/serialize.py
+++ b/distributed/protocol/serialize.py
@@ -611,8 +611,12 @@ def nested_deserialize(x):
x[k] = replace_inner(v)
elif typ is Serialize:
x[k] = v.data
+ elif typ is ToPickle:
+ x[k] = v.data
elif typ is Serialized:
x[k] = deserialize(v.header, v.frames)
+ elif typ is Pickled:
+ x[k] = pickle.loads(v.header, buffers=v.frames)
elif type(x) is list:
x = list(x)
@@ -622,8 +626,12 @@ def nested_deserialize(x):
x[k] = replace_inner(v)
elif typ is Serialize:
x[k] = v.data
+ elif typ is ToPickle:
+ x[k] = v.data
elif typ is Serialized:
x[k] = deserialize(v.header, v.frames)
+ elif typ is Pickled:
+ x[k] = pickle.loads(v.header, buffers=v.frames)
return x
|
mrocklin
added a commit
to mrocklin/distributed
that referenced
this pull request
Mar 31, 2022
Contributor
|
#6044 should fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files