Skip to content

Drop runtime dependency to setuptools#6017

Merged
crusaderky merged 2 commits intodask:mainfrom
crusaderky:setuptools
Mar 29, 2022
Merged

Drop runtime dependency to setuptools#6017
crusaderky merged 2 commits intodask:mainfrom
crusaderky:setuptools

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Mar 29, 2022 •
edited
Loading

setuptools now remains exclusively in setup.py and conda meta.yaml.
It is also optionally used by versioneer, with a transparent fallback to distutils if it's not already loaded.

twin of

xrefs

@crusaderky crusaderky self-assigned this Mar 29, 2022
@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Mar 29, 2022

I can see a wealth of differences between

  • dask/continuous_integration/recipe/meta.yaml
    and
  • distributed/continuous_integration/recipes/dask/meta.yaml

I expect one of the two files to be unused?

CC @jsignell

@crusaderky crusaderky mentioned this pull request Mar 29, 2022
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2022 •
edited
Loading

Unit Test Results

       12 files  +       4         12 suites  +4   6h 38m 10s ⏱️ + 2h 37m 5s
  2 675 tests +       3    2 591 ✔️ +     12    81 💤  -   11  3 ❌ +2 
15 954 runs  +5 298  15 089 ✔️ +5 012  862 💤 +284  3 ❌ +2 

For more details on these failures, see this check.

Results for commit a7896e9. ± Comparison against base commit ed48736.

♻️ This comment has been updated with latest results.

@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Mar 29, 2022

All failures unrelated.
linting failure: #6019

@jsignell
Copy link
Copy Markdown
Member

jsignell commented Mar 29, 2022

My understanding is that there recipes are exclusively used for nightly builds. @charlesbluca @jakirkham

@charlesbluca
Copy link
Copy Markdown
Member

charlesbluca commented Mar 29, 2022

My understanding is that there recipes are exclusively used for nightly builds

Correct, both are used in this workflow to build / publish nightlies on every commit.

I expect one of the two files to be unused?

Both are being used, with dask/continuous_integration/recipe/meta.yaml generating dask-core nightlies and distributed/continuous_integration/recipes/dask/meta.yaml generating dask metapackage nightlies

@crusaderky crusaderky merged commit 852d5f5 into dask:main Mar 29, 2022
@crusaderky crusaderky deleted the setuptools branch March 29, 2022 22:00
@crusaderky crusaderky mentioned this pull request Mar 29, 2022
Merged
mrocklin pushed a commit to mrocklin/distributed that referenced this pull request Mar 31, 2022
@crusaderky @mrocklin
Drop runtime dependency to setuptools (dask#6017)
1796804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter fjetter approved these changes

Assignees

@crusaderky crusaderky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crusaderky @jsignell @charlesbluca @fjetter