Fix flaky test_shuffle_extension.py::test_get_partition#5689
Merged
crusaderky merged 2 commits intodask:mainfrom Jan 24, 2022
Merged
Fix flaky test_shuffle_extension.py::test_get_partition#5689crusaderky merged 2 commits intodask:mainfrom
test_shuffle_extension.py::test_get_partition#5689crusaderky merged 2 commits intodask:mainfrom
Conversation
`ext.get_output_partition(metadata.id, 7)` was making an assumption about the order of the workers passed by `gen_cluster` matching the order of `scheduler.workers`, which is not guaranteed.
gjoseph92
commented
Jan 24, 2022
Comment on lines
+264
to
+267
| for addr, ext in exts.items(): | ||
| if metadata.worker_for(0) != addr: | ||
| with pytest.raises(AssertionError, match="belongs on"): | ||
| ext.get_output_partition(metadata.id, 0) |
Collaborator
Author
There was a problem hiding this comment.
This is the change that fixes the flaky test. The rest are just drivebys for readability.
Collaborator
|
LGTM - however it doesn't close #5688; the issue reports 3 other tests, all around rebalance(), that became flaky. |
Collaborator
Author
|
Let's move the rebalance discussion to #5688 for now. |
gjoseph92
added a commit
to gjoseph92/distributed
that referenced
this pull request
Jan 24, 2022
gjoseph92
added a commit
to gjoseph92/distributed
that referenced
this pull request
Jan 24, 2022
gjoseph92
added a commit
to gjoseph92/distributed
that referenced
this pull request
Jan 24, 2022
Collaborator
Author
|
I'll open separate PRs for other things; I think we should merge this one now. cc @jrbourbeau |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test was assuming the order of the workers passed by
gen_clustermatched the order ofscheduler.workers, which is not guaranteed.I reread all the rest of the tests and didn't see any other such potential issues. But I did make a couple small tweaks to improve readability.
pre-commit run --all-files