Fix-up test_pickle_empty
#5303
Merged
Fix-up test_pickle_empty
#5303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6bec32 to
881d643
Compare
Member
Author
|
@dask/maintenance could someone please review? 🙂 This is needed to fix |
Member
Author
|
Planning on merging EOD tomorrow if no comments |
jacobtomlinson
approved these changes
Sep 10, 2021
Member
Author
|
Thanks Jacob! 😄 |
This was referenced Sep 10, 2021
Member
Author
|
To help catch the kind of issue seen in cloudpickle's CI earlier, am adding explicit testing of pickle protocol 4 & 5 in PR ( #5313 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on and extends PR ( #4595 ). Should address a CI failure seen in PR ( cloudpipe/cloudpickle#432 ).
Switches to using the internal utility class
MemoryviewHolderinstead of NumPy to allow testing without NumPy. Callsserializedirectly withpickleas the only option (instead of callingpickle_dumps). Though alsoasserts pickling did occur. Also includes some other minor fixes.Only tries manipulating writability of frames with pickle protocol 5 in use. This doesn't work for earlier pickle protocols as there is only one
bytesobject containing everything (and no way to inspect what went into it, let alone reproduce it).cc @madsbk @pierreglaser
black distributed/flake8 distributed/isort distributed